Updated 'column_definitions_sql' to ensure that only primary key key constraints are queried for #851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…constraints are queried for
Member
|
Looks good at first glance, but I'd like to double check with a minimal reproducible script before merging. Do you think we could write a test for this? |
Contributor
Author
|
I'll take a look at writing a test for this, yes! |
Contributor
Author
|
@wpolicarpo All pushed up 😄 I reverted my change while writing the test, so I am sure that the test will fail if there is another regression. All tests were passing locally |
Member
|
Thanks for the contribution @BenMcH. I'll cut a new release soon. |
Contributor
Author
|
Thank you @wpolicarpo! We look forward to pulling in the update 😄 |
Contributor
Author
|
@wpolicarpo is this going to be released soon? |
Member
|
Sorry for the delay here @BenMcH. I'll cut a new release today or tomorrow, I promise. |
Member
|
Version 6.0.1 released with your fix @BenMcH. |
Contributor
Author
|
Thank you, @wpolicarpo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #850
Upon investigation into this query, I discovered that the new query is looking at the table
sys.key_constraintswhich includes both primary keys as well as unique constraints, which is not what we want.Originally, I tried adding this check to the
whereclause, but my schema dump was missing any table without a primary key. After adding this to the join, I was able to successfully dump my schema, build a test database, and run my specs successfully against the new test database.CC @wpolicarpo